fix(database_task): check schema_migration table check to connection pool #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgmontoya
force-pushed
the
fix/prepare-with-data-task
branch
4 times, most recently
from
050574d
to
f16a4d5
Compare
jgmontoya
force-pushed
the
fix/prepare-with-data-task
branch
from
f16a4d5
to
7a48deb
Compare
vprigent
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
I'm getting an error for Rails 6.1 however its not related to your changes as far as I know (and as you mentioned, your patch fixes another error coming from Rails 6.1 too).
While I'd be keen to extend support for older versions, we haven't added a single new feature to data_migrate in 11.x that's relevant for older Rails versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
db:prepare:with_datatask is broken for rails 7.2 after this change: rails/rails#51162This PR moves the check to use the proper method
database_exists?I removed a test file that was probably introduced by mistake.
I also refactored the task a bit to try and make it compatible with rails 6.1 (not 100% sure if it's working now, but I know for sure it wasn't before 😅) and added some tests for the task.